Changeset 1079

Timestamp:

08/02/07 23:29:10 (3 years ago)

Author:

ahu

Message:

plug memory leak on packet building error caused by bogus database information

Files:

• trunk/pdns/pdns/packethandler.cc (modified) (2 diffs)

trunk/pdns/pdns/packethandler.cc

@@ -897 +897 @@
     if(doAdditionalProcessingAndDropAA(p,r)<0)
       return 0;
+
     r->wrapup(); // needed for inserting in cache
     if(!noCache)
@@ -907 +908 @@
     S.ringAccount("servfail-queries",p->qdomain);
   }
+  catch(exception &e) {
+    L<<Logger::Error<<"Exception building anser packet ("<<e.what()<<") sending out servfail"<<endl;
+    delete r;
+    r=p->replyPacket();  // generate an empty reply packet    
+    r->setRcode(RCode::ServFail);
+    S.inc("servfail-packets");
+    S.ringAccount("servfail-queries",p->qdomain);
+  }
   return r;