Changeset 2123 for trunk/pdns/pdns/pdns_recursor.cc

Timestamp:

04/03/11 17:23:15 (2 years ago)

Author:

ahu

Message:

remove some further unaligned memory accesses in powerdns recursor

Files:

• trunk/pdns/pdns/pdns_recursor.cc (modified) (1 diff)

trunk/pdns/pdns/pdns_recursor.cc

@@ -816 +816 @@
       ageDNSPacket(response, age);
       sendto(fd, response.c_str(), response.length(), 0, (struct sockaddr*) &fromaddr, fromaddr.getSocklen());
-      if(response.length() >= sizeof(struct dnsheader))
-        updateRcodeStats(((struct dnsheader*)response.c_str())->rcode);
+      if(response.length() >= sizeof(struct dnsheader)) {
+        struct dnsheader dh;
+        memcpy(&dh, response.c_str(), sizeof(dh));
+        updateRcodeStats(dh.rcode);
+      }
       g_stats.avgLatencyUsec=(uint64_t)((1-0.0001)*g_stats.avgLatencyUsec + 0); // we assume 0 usec
       return 0;