Changeset 2609

Timestamp:

05/09/12 12:41:52 (12 months ago)

Author:

peter

Message:

stop logging postgres database password in gpgsql connection errors. Fixes #459, reported by Stefan Kaltenbrunner.

Location:

trunk/pdns/modules/gpgsqlbackend

Files:

• spgsql.cc (modified) (2 diffs)
• spgsql.hh (modified) (1 diff)

trunk/pdns/modules/gpgsqlbackend/spgsql.cc

@@ -27 +27 @@
     d_connectstr+=" port="+port;
 
-  if(!password.empty())
+  d_connectlogstr=d_connectstr;
+
+  if(!password.empty()) {
+    d_connectlogstr+=" password=XXX";
     d_connectstr+=" password="+password;
+  }
   
   ensureConnect();
@@ -56 +60 @@
   if (!d_db || PQstatus(d_db)==CONNECTION_BAD) {
     try {
-      throw sPerrorException("Unable to connect to database, connect string: "+d_connectstr);
+      throw sPerrorException("Unable to connect to database, connect string: "+d_connectlogstr);
     }
     catch(...) {

trunk/pdns/modules/gpgsqlbackend/spgsql.hh

@@ -27 +27 @@
   PGconn* d_db; 
   string d_connectstr;
+  string d_connectlogstr;
   PGresult* d_result;
   int d_count;