Changeset 661

Timestamp:

04/05/06 17:34:32 (7 years ago)

Author:

ahu

Message:

ok - this is a scary commit. It fixes TCP packets with >16384 size offsets, which is nice, but it also removes some logic
that looks remarkably well thought out but also appeared to serve no purpose. But perhaps it was magic..

Files:

• trunk/pdns/pdns/dnswriter.cc (modified) (1 diff)

trunk/pdns/pdns/dnswriter.cc

@@ -140 +140 @@
       goto out;                                 // skip trailing 0 in case of compression
     }
-    else if(compress || d_labelmap.count(chopped)) { // if 'compress' is true, li will be equal to d_labelmap.end()
-      d_labelmap[chopped]=pos;                       //  if untrue, we need to count 
+    
+    if(compress && pos < 16384) { 
+      d_labelmap[chopped]=pos;                       //  if untrue, we need to count - also, don't store offsets > 16384, won't work
     }
     d_record.push_back((char)(i->second - i->first));