Ticket #219 (closed enhancement: fixed)

Opened 5 years ago

Last modified 2 years ago

Accept NOTIFY from masters on non-standard port

Reported by: anon Owned by: somebody
Priority: normal Milestone:
Component: component1 Version: 2.0
Severity: normal Keywords:
Cc: shane@…

Description

This is related to ticket 211 which adds support for masters on non-standard ports:

 http://wiki.powerdns.com/cgi-bin/trac.fcgi/ticket/211

With the changes in that ticket, PowerDNS will accept the NOTIFY messages, but it would then attempt to do an SOA check on port 53 from the IP address that sent them. This of course does not work. :)

The attached patch changes the server so that it will use the port defined for the master as the target of the SOA check. (Note that it only does this for the SQL backend, and not the BIND backend. I don't think the BIND backend supports masters on non-standard ports.)

The right way to do this is probably to have the SOA check be handled in the code that performs the XFR. That way a NOTIFY would simply schedule an immediate zone update rather than perform the SOA check. But the method here works.

Attachments

notify-accept.diff Download (5.6 KB) - added by anon 5 years ago.
notify-accept-incremental.diff Download (5.3 KB) - added by anon 5 years ago.
Incremental patch to apply after the patches in ticket #211

Change History

Changed 5 years ago by anon

Oh, forgot to attribute this. You can send questions to the development list, or contact me directly at:

Shane Kerr
shane@…

Changed 5 years ago by anon

Changed 5 years ago by anon

Incremental patch to apply after the patches in ticket #211

Changed 2 years ago by peter

  • status changed from new to closed
  • resolution set to fixed

Presumably fixed when #211 got fixed in PowerDNS 3.0.

Note: See TracTickets for help on using tickets.